Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update specs to conform to ConversionHost validations #294

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Update specs to conform to ConversionHost validations #294

merged 1 commit into from
Feb 12, 2019

Conversation

djberg96
Copy link
Contributor

The ConversionHost model added validations in ManageIQ/manageiq#18434 which broke this repo. This PR fixes it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2092

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 80.73%
Totals Coverage Status
Change from base Build 2091: 0.2%
Covered Lines: 5266
Relevant Lines: 6523
💛 - Coveralls

@gmcculloug gmcculloug self-assigned this Feb 12, 2019
@gmcculloug gmcculloug merged commit 6eb4873 into ManageIQ:master Feb 12, 2019
@gmcculloug gmcculloug added this to the Sprint 105 Ending Feb 18, 2019 milestone Feb 12, 2019
@gmcculloug
Copy link
Member

gmcculloug commented Mar 31, 2019 •
edited
Loading

@simaishi This PR needs to be back-ported to hammer to resolve failing tests due to back-port of ManageIQ/manageiq#18277. hammer/yes label added.

https://travis-ci.org/ManageIQ/manageiq-automation_engine/branches

simaishi pushed a commit that referenced this pull request Apr 22, 2019
@gmcculloug @simaishi
Merge pull request #294 from djberg96/conversion_host_update
4df84ff 
Update specs to conform to ConversionHost validations

(cherry picked from commit 6eb4873)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 4df84ff1cde224ef13ae2c93cf127aa7cb42c271
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Feb 12 09:08:17 2019 -0500

    Merge pull request #294 from djberg96/conversion_host_update
    
    Update specs to conform to ConversionHost validations
    
    (cherry picked from commit 6eb4873b7fc31d52c97121e091c6adaf1becae17)

@Fryguy Fryguy added v2v and removed transformation labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
hammer/backported test v2v
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djberg96 @coveralls @gmcculloug @simaishi @Fryguy