permit_concurrent_loads is not needed with zeitwerk autoloader #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jrafanie
changed the title
This was only needed for classic autoloader. The core "freedom" patch made zeitwerk autoloader bypass the interlock anyway, so now that we're only supporting zeitwerk, this is no longer needed. Co-dependency: ManageIQ/manageiq#22801 Part of the rails 7 upgrade: ManageIQ/manageiq#22052
jrafanie
force-pushed
the
drop_as_dependencies_interlock_with_classic_autoloader_gone
branch
from
31df202
to
f685f12
Compare
|
Some comments on commit jrafanie@f685f12 lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_method.rb
|
|
Checked commit jrafanie@f685f12 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
This is ready to go since we were already defaulting to zeitwerk on quinteros |
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Jan 5, 2024
…with_classic_autoloader_gone permit_concurrent_loads is not needed with zeitwerk autoloader (cherry picked from commit 29852c4)
jrafanie
deleted the
drop_as_dependencies_interlock_with_classic_autoloader_gone
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only needed for classic autoloader. The core "freedom" patch made zeitwerk autoloader bypass the interlock anyway, so now that we're only supporting zeitwerk, this is no longer needed.
Co-dependency:
ManageIQ/manageiq#22801
Part of the rails 7 upgrade: ManageIQ/manageiq#22052