Add cloud_subnets to availability zone test #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
d-m-u
changed the title
|
Checked commit d-m-u@e6fe94f with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
d-m-u
changed the title
d-m-u
changed the title
|
@miq-bot add_label test |
|
@miq-bot add_label gaprindashvili/yes |
simaishi
pushed a commit
that referenced
this pull request
Jan 12, 2018
…oud_networks Add cloud_subnets to availability zone test (cherry picked from commit 4e16a37) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1533277
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cloud network list was only updated after selection of security group, or change of tab, or a select set of other actions that completely voided the list of parameters passed to the filtering method. This adds a change so that availability zone updates the selection of cloud network, preventing incorrect cloud networks from showing up in the after the zone dropdown changes. This issue was fixed in ManageIQ/manageiq#16688. The google provider test broke because the availability zone wasn't set up to have any subnets which was exposed because of the filtering changes in 16688. This should fix that by adding a network manager to the existing test ems, forcing the ems to not return a nil on the cloud subnet association.
Related to:
ManageIQ/manageiq#16811
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1518847