Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AuthPrivateKey decorator to Authentication decorator #4

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Change AuthPrivateKey decorator to Authentication decorator #4

merged 1 commit into from
Apr 15, 2019

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Apr 15, 2019

Authentication is the base class, AuthPrivateKey a child.
Previously (ManageIQ/manageiq#18633) CloudManager::AuthKeyPair inherited from AuthPrivateKey, but changed to Authentication now.

So, moving the decorator to cover the whole base class.
(Not seeing any problem with AuthToken, AuthUseridPassword, and ManageIQ::Providers::AutomationManager::Authentication also gaining a decorator because of this.)

(Fixes failing travis on ui-classic master:

  1) AuthKeyPairCloudController#report_data when tile mode is selected returns key pairs with quadicons
     Failure/Error: expect(results['data']['rows'][0]['quad']).to have_key('fonticon')
       expected  to respond to `has_key?`
     # ./spec/controllers/auth_key_pair_cloud_controller_spec.rb:98

)

Cc @skateman , @agrare

Authentication is the base class, AuthPrivateKey a child.
Previously (ManageIQ/manageiq#18633) CloudManager::AuthKeyPair inherited from AuthPrivateKey, but changed to Authentication now.

So, moving the decorator to cover the whole base class.
(Not seeing any problem with AuthToken, AuthUseridPassword, and ManageIQ::Providers::AutomationManager::Authentication also gaining a decorator because of this.)
@himdel
Copy link
Contributor Author

himdel commented Apr 15, 2019

(Verified ui-classic spec and rake in this repo is passing locally for me with this change.)

@skateman skateman merged commit 1dda154 into ManageIQ:master Apr 15, 2019
@himdel himdel deleted the fix-authentication branch April 15, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants