-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract VMwareWebServices #169
Conversation
b4396f5
to
4a639e0
Compare
c2e5758
to
80bb2fc
Compare
This pull request is not mergeable. Please rebase and repush. |
80bb2fc
to
3f583c5
Compare
This pull request is not mergeable. Please rebase and repush. |
3f583c5
to
d406377
Compare
This pull request is not mergeable. Please rebase and repush. |
d406377
to
367c4c9
Compare
manageiq-gems-pending.gemspec
Outdated
@@ -32,7 +32,6 @@ Gem::Specification.new do |s| | |||
s.add_runtime_dependency "bunny", "~>2.1.0" | |||
s.add_runtime_dependency "excon", "~>0.40" | |||
s.add_runtime_dependency "ffi", "~>1.9.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerryk55 can I remove ffi
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agrare I am not aware of any other use of FFI other than by ffi-vix_disk_lib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!
0846521
to
15c3bff
Compare
1d9ac0b
to
520ab36
Compare
520ab36
to
8d79183
Compare
8d79183
to
c87978c
Compare
Checked commits agrare/manageiq-gems-pending@573408d~...c87978c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Extracting to new repo https://github.com/ManageIQ/vmware_web_service
Also need: ManageIQ/manageiq#15221