Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract VMwareWebServices #169

Merged
merged 7 commits into from
May 24, 2017
Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented May 19, 2017

@miq-bot miq-bot added the wip label May 19, 2017
@agrare agrare force-pushed the move_vmware_web_services branch 4 times, most recently from c2e5758 to 80bb2fc Compare May 22, 2017 13:47
@miq-bot
Copy link
Member

miq-bot commented May 23, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented May 23, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented May 24, 2017

This pull request is not mergeable. Please rebase and repush.

@@ -32,7 +32,6 @@ Gem::Specification.new do |s|
s.add_runtime_dependency "bunny", "~>2.1.0"
s.add_runtime_dependency "excon", "~>0.40"
s.add_runtime_dependency "ffi", "~>1.9.3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerryk55 can I remove ffi as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agrare I am not aware of any other use of FFI other than by ffi-vix_disk_lib.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@agrare agrare force-pushed the move_vmware_web_services branch 3 times, most recently from 0846521 to 15c3bff Compare May 24, 2017 19:55
@agrare agrare changed the title [WIP] Extract VMwareWebServices Extract VMwareWebServices May 24, 2017
@agrare agrare removed the wip label May 24, 2017
@agrare agrare force-pushed the move_vmware_web_services branch 2 times, most recently from 1d9ac0b to 520ab36 Compare May 24, 2017 20:33
@agrare agrare closed this May 24, 2017
@agrare agrare reopened this May 24, 2017
@miq-bot
Copy link
Member

miq-bot commented May 24, 2017

Checked commits agrare/manageiq-gems-pending@573408d~...c87978c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@chessbyte chessbyte assigned chessbyte and unassigned Fryguy May 24, 2017
@chessbyte chessbyte merged commit 1144dbe into ManageIQ:master May 24, 2017
@chessbyte chessbyte added this to the Sprint 62 Ending Jun 5, 2017 milestone May 24, 2017
@agrare agrare deleted the move_vmware_web_services branch May 24, 2017 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants