Dont mess with pglogical from PostgresAdmin #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will handle this in the main app rake task before we even get to this class to do the restore. This will be cleaner as we can use all the tooling we have built up around the extension there rather than shelling out to psql from here https://bugzilla.redhat.com/show_bug.cgi?id=1540686
|
Checked commit carbonin@d8c0f08 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
gtanzillo
approved these changes
Feb 2, 2018
carbonin
changed the title
|
Marking as WIP until ManageIQ/manageiq#16942 is merged |
carbonin
changed the title
simaishi
pushed a commit
that referenced
this pull request
Mar 9, 2018
Dont mess with pglogical from PostgresAdmin (cherry picked from commit d2d138f) https://bugzilla.redhat.com/show_bug.cgi?id=1553903
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of ManageIQ/manageiq#16942 we handle this in the main app rake task before we even get to this class to do the restore.
This will be cleaner as we can use all the tooling we have built up around the extension there rather than shelling out to psql from here.
https://bugzilla.redhat.com/show_bug.cgi?id=1540686