Remove miq-uuid.rb and specs #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems you missed a few spots |
|
Checked commits https://github.com/djberg96/manageiq-gems-pending/compare/9fd2e4f199c0c0a55f6959f2219aa76a34d5b449~...4dd267a25be8034c105ac7b8737631ee7842799d with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
@Fryguy Looks like there was a single spec file that required it, but wasn't actually using it. Not sure why it was there. Anyway, fixed. |
Fryguy
approved these changes
Aug 4, 2020
|
I couldn't find in any Miq repo. LGTM |
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiqUUID.clean_guidwas replaced withDigest::UUID.cleanand updated in core so this PR removes it from gems-pending.Followup to ManageIQ/more_core_extensions#81 and ManageIQ/manageiq#20403