Fix simplecov handling for codeclimate via GitHub Actions #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the tests, we need to make sure the CC_TEST_REPORTER_ID value is present. This allows SimpleCov to generate the JSON payload that is needed for Code Climate, as SimpleCov has special handling when that env var is present.
Fryguy
force-pushed
the
github_actions3
branch
from
7e44222
to
40bbd9b
Compare
|
Checked commits Fryguy/manageiq-gems-pending@384249c~...40bbd9b with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
bdunne
reviewed
Dec 14, 2021
| @@ -1,5 +1,5 @@ | |||
| require "simplecov" | |||
| SimpleCov.start { command_name "spec" } | |||
There was a problem hiding this comment.
I thought we needed these to prevent one test suite from overwriting all of the data from the previous one
There was a problem hiding this comment.
Perhaps in the past, but the current version of SimpleCov automatically creates two sections named "RSpec" and "Unit tests" for rpsec and minitest respectively. This keeps the defaults, and then SimpleCov automatically merges them together into the JSON payload when it sees CC_TEST_REPORTER_ID as an env var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the tests, we need to make sure the CC_TEST_REPORTER_ID
value is present. This allows SimpleCov to generate the JSON payload
that is needed for Code Climate, as SimpleCov has special handling when
that env var is present.
Also fix calling of minitest based tests