Allow users to input ipv6 where it makes sense #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It feels like this will probably come close to solving https://bugzilla.redhat.com/show_bug.cgi?id=1212896 Do you want to take that @isimluk? |
When users inputs static IPv4 we should assert it is valid IPv4. All other inputs shall allow for IPv6 as well. This commit does not allow IPv6 yet, it just makes the logical distinction.
|
Sure, taking, working on it anyway. It will get fixed in one of the following prs. |
isimluk
changed the title
|
We will need new prompt for static ipv6 as things are different and people may want to have both. |
|
Checked commits https://github.com/isimluk/manageiq-gems-pending/compare/ee3769eac683f1bd878077a344b58b248db52dfd~...4f7202e22037c29565111a92d2152876841c4c65 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Getting this into the build early will make my job easier, when I will try to set-up multi region, multi-zone over ipv6. Thanks! |
carbonin
approved these changes
Feb 23, 2017
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In many prompts we allow users to put IP address. In some prompts it makes sense to only accept IPv4 addresses (when setting up static IPv4). In other cases it makes sense to accept IPv4 or IPv6.
This PR makes
Test Network Configurationto magically work with IPv6.I'll continue to work with other dialogs to make sure, we are able to process IPv6. However, we can allow IPv6 inputs to be valid now.