CP4AIOPS-3113 pass delimiter for groups #1155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kbrock
force-pushed
the
delimiters
branch
2 times, most recently
from
f905bad
to
aa1ad9b
Compare
kbrock
changed the title
|
update:
|
kbrock
force-pushed
the
delimiters
branch
2 times, most recently
from
855734b
to
3e17b6e
Compare
Fryguy
reviewed
Sep 4, 2024
| RequestHeader set X_REMOTE_USER_FIRSTNAME %%{OIDC_CLAIM_GIVEN_NAME}e env=OIDC_CLAIM_GIVEN_NAME | ||
| RequestHeader set X_REMOTE_USER_LASTNAME %%{OIDC_CLAIM_FAMILY_NAME}e env=OIDC_CLAIM_FAMILY_NAME | ||
| RequestHeader set X_REMOTE_USER_FULLNAME %%{OIDC_CLAIM_NAME}e env=OIDC_CLAIM_NAME | ||
| RequestHeader set X_REMOTE_USER_GROUP_DELIMITER "," |
There was a problem hiding this comment.
Minor, but in the other PR, this entry came after X_REMOTE_USER_GROUPS
MellonMergeEnvVars On brings back all groups for REMOTE_USER_GROUPS By default, the delimiter is ;, but this can be overridden This is a no-op, but it highlights that a semicolon is used to join groups. Liberty (via oidc) is using a comma, but that is not displayed here. LookupUserGroups specifies a ":"
|
update:
|
|
Checked commits kbrock/manageiq-pods@b9b68cd~...5104e9e with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
1 similar comment
|
Checked commits kbrock/manageiq-pods@b9b68cd~...5104e9e with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receiving end (ruby code) will use this delimiter to separate classes. Since the various components use different delimiters, it is easiest to configure this in one place and pass it around
see also ManageIQ/manageiq#23139