-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase PG Pod resource requirements #188
Conversation
- Provide reasonable minimum default resource requests for a PG/MIQ deployment on OpenShift - Increased shared_buffers to 1GB - Increased minimum RAM resource request to 4GB - References : https://wiki.postgresql.org/wiki/Tuning_Your_PostgreSQL_Server https://access.redhat.com/documentation/en-us/red_hat_cloudforms/4.5/html/deployment_planning_guide/introduction#virtual-hardware-requirements
templates/miq-template.yaml
Outdated
@@ -841,7 +841,7 @@ parameters: | |||
displayName: PostgreSQL Min RAM Requested | |||
required: true | |||
description: Minimum amount of memory the PostgreSQL container will need. | |||
value: 1024Mi | |||
value: 4096Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be 4Gi
?
templates/miq-template.yaml
Outdated
@@ -784,7 +784,7 @@ parameters: | |||
- name: POSTGRESQL_SHARED_BUFFERS | |||
displayName: PostgreSQL Shared Buffer Amount | |||
description: Amount of memory dedicated for PostgreSQL shared memory buffers. | |||
value: 256MB | |||
value: 1024MB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be 1GB
?
I'm okay with this. For development I'm already clearing out all the requests and limits and letting my minishift VM swap. |
Checked commits fbladilo/manageiq-pods@18130ea~...2841b6f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Adjusted size suffixes to Gigs... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
@carbonin @bdunne Follow up on this one...
https://wiki.postgresql.org/wiki/Tuning_Your_PostgreSQL_Server
https://access.redhat.com/documentation/en-us/red_hat_cloudforms/4.5/html/deployment_planning_guide/introduction#virtual-hardware-requirements
The kubernetes scheduler will only attempt a pod placement on a node that satisfies the minimum request, the shared buffer calculation is taken from the PG tuning guide at 1/4 of the available RAM. In this case, we calculate from the minimum memory request (guaranteed) and not the max memory limit set by default at 8GB and enforced via cgroups.