Update ruby rails dependencies (breaking change) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be safe to use as is since the core application sets the rails version. This will allow us to test with other versions on master.
39 tasks
Fryguy
reviewed
Sep 24, 2024
Gemfile
Outdated
| "~>7.2.1" | ||
| when "7.1" | ||
| "~>7.1.4" | ||
| else "7.0" |
There was a problem hiding this comment.
I think this will actually created a combined string like "7.0~>7.0.8" cause it will see two strings side by side.
There was a problem hiding this comment.
Interesting, it's a bug but I think it does the right thing. Let me fix it.
There was a problem hiding this comment.
That was a wild goose chase... but I'll fix this and test with ruby 3.0-3.3 and rails 7.0-7.2.
There was a problem hiding this comment.
done... checking ci results...
Fryguy
reviewed
Sep 24, 2024
| @@ -12,13 +12,13 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| ruby-version: | |||
| - '2.7' | |||
| - '3.0' | |||
There was a problem hiding this comment.
I thought our app still supported 3.0?
There was a problem hiding this comment.
3.0 is end of life but I can keep it around. I guess the same can be said about rails 6.1.
Ensure we're testing and supporting community supported versions. Drop: * ruby 2.7 * rails 6.0 * rails 6.1 Add: * ruby 3.2 * ruby 3.3 * rails 7.1 * rails 7.2 Note: ruby 3.0 is not difficult to keep maintaining for now but it's on the chopping block.
jrafanie
force-pushed
the
update_ruby_rails_dependencies
branch
from
5d019bf
to
a82cd58
Compare
Fryguy
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use core minimum but allow 7.0/7.1/7.2 since core sets upper limit
Drop end of life rubies and rails and add new versions
Ensure we're testing and supporting community supported
versions.
Drop:
Add:
Note: ruby 3.0 is not difficult to keep maintaining for now but it's on the chopping block.