Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory collection refresh using inventory abstraction #102

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Jan 12, 2017

Inventory collection refresh using inventory abstraction, separating inventory collection from parsing and moving to hash format sent into parser, so the parser works for event based data as well

Change AWS Cloud Refresher to the new format separating collection
from parsing. We use Inventory abstraction for the inventory collection
and parsing.
Change AWS Network Refresher to the new format separating  collection
from parsing. We use Inventory abstraction for the inventory
collection and parsing.
Cloud parser for InventoryObjects using Inventory abstraction,
we also work with hashes instead of objects, so the same parser
can be used for the event data.
Network parser for InventoryObjects using Inventory abstraction,
we also work with hashes instead of objects, so the same parser
can be used for the event data.
Change VCR spec counts caused by refreshing VCRs
AWS refreshed VCRs
Change counts to pass CI
@miq-bot
Copy link
Member

miq-bot commented Jan 12, 2017

Some comments on commits Ladas/manageiq-providers-amazon@e17b368~...0bfcd49

spec/vcr_cassettes/manageiq/providers/amazon/cloud_manager/refresher.yml

  • 💣 💥 🔥 🚒 - 11264 - Detected cfme

spec/vcr_cassettes/manageiq/providers/amazon/cloud_manager/refresher_inventory_object.yml

  • 💣 💥 🔥 🚒 - 9296 - Detected cfme

@miq-bot
Copy link
Member

miq-bot commented Jan 12, 2017

Checked commits Ladas/manageiq-providers-amazon@e17b368~...0bfcd49 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
5 files checked, 17 offenses detected

app/models/manageiq/providers/amazon/cloud_manager/refresh_parser_inventory_object.rb

app/models/manageiq/providers/amazon/cloud_manager/refresher.rb

app/models/manageiq/providers/amazon/network_manager/refresh_parser_inventory_object.rb

app/models/manageiq/providers/amazon/network_manager/refresher.rb

@durandom durandom merged commit afcdc38 into ManageIQ:master Jan 13, 2017
gberginc added a commit to gberginc/manageiq-providers-amazon that referenced this pull request Jan 13, 2017
Similarly to
ManageIQ#102 this
patch adds support for inventory collection using inventory abstraction.
Corresponding targets as well as the refresh parser inventory object. It
mimics existing cloud and network managers.

Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
gberginc added a commit to gberginc/manageiq-providers-amazon that referenced this pull request Jan 17, 2017
Similarly to
ManageIQ#102 this
patch adds support for inventory collection using inventory abstraction.
Corresponding targets as well as the refresh parser inventory object. It
mimics existing cloud and network managers.

Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
gberginc added a commit to gberginc/manageiq-providers-amazon that referenced this pull request Jan 17, 2017
Similarly to
ManageIQ#102 this
patch adds support for inventory collection using inventory abstraction.
Corresponding targets as well as the refresh parser inventory object. It
mimics existing cloud and network managers.

Signed-off-by: Gregor Berginc <gregor.berginc@xlab.si>
@Ladas Ladas added the euwe/no label Jan 17, 2017
aiperon added a commit to aiperon/manageiq-providers-amazon that referenced this pull request Jan 18, 2017
Similarly to ManageIQ#102.
Adds support for inventory collection using inventory abstraction.
It mimics existing cloud, network and ebs managers.
aiperon added a commit to aiperon/manageiq-providers-amazon that referenced this pull request Jan 18, 2017
Similarly to ManageIQ#102.
Adds support for inventory collection using inventory abstraction.
It mimics existing cloud, network and ebs managers.
aiperon added a commit to aiperon/manageiq-providers-amazon that referenced this pull request Jan 18, 2017
Similarly to ManageIQ#102.
Adds support for inventory collection using inventory abstraction.
It mimics existing cloud, network and ebs managers.
aiperon added a commit to aiperon/manageiq-providers-amazon that referenced this pull request Jan 18, 2017
Similarly to ManageIQ#102.
Adds support for inventory collection using inventory abstraction.
It mimics existing cloud, network and ebs managers.
aiperon added a commit to aiperon/manageiq-providers-amazon that referenced this pull request Jan 18, 2017
Similarly to ManageIQ#102.
Adds support for inventory collection using inventory abstraction.
It mimics existing cloud, network and ebs managers.
aiperon added a commit to aiperon/manageiq-providers-amazon that referenced this pull request Jan 18, 2017
Similarly to ManageIQ#102.
Adds support for inventory collection using inventory abstraction.
It mimics existing cloud, network and ebs managers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants