Pass collector to persister to make targeted refresh work #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass collector to persistor, before we figure out how to pass references. It will be probably through target.
Use changed init schema and manager instead of ems
Ladas
force-pushed
the
pass_collector_to_persister_to_make_targeted_refresh_work
branch
from
8a220b2
to
700dfb6
Compare
|
Checked commits Ladas/manageiq-providers-amazon@ede7755~...700dfb6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
durandom
reviewed
Feb 23, 2017
| @@ -1,5 +1,5 @@ | |||
| class ManageIQ::Providers::Amazon::Inventory::Collector::TargetCollection < ManageIQ::Providers::Amazon::Inventory::Collector | |||
| def initialize(_ems, _options, _target) | |||
| def initialize(_manager, _target) | |||
There was a problem hiding this comment.
would be great to move the whole amazon refresh to use the stock initializers :)
|
Isnt there a spec for this? Or how do you test it? |
|
@durandom specs are on the way :-) I need to first figure out what the right target is :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temporary solution to make Targeted refresh work. We need to figure out a right place to parse all references that relate to a Target and passing them to Colletor and Persister