add amazon events to settings to display them in timelines #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
|
@adahms please let me know if you need anything more from me |
|
Checked commit durandom@e225bfc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
looks great, (a side note, we should add also CloudWatch events, I will probably do that :-)) |
|
@durandom - Did you mean to refer to ManageIQ/manageiq#14177? |
bronaghs
approved these changes
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timelines have been enabled for aws for a long time
and we have been collecting events for some time.
We just did not display any events by default.
Display those 6 EC2 events because we already have them
in automate triggering a refresh
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1392391
since ManageIQ/manageiq#13942 has been merged, I can add those events here 😋
@blomquisg @bronaghs please review