Add support snapshot_create to EBS cloud volume #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support in the backend was already there but the missing `supports` prevented UI from showing the corresponding menu item.
|
looks good, will merge when green 👍 |
|
Checked commit gberginc@1e50b63 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Ladas
reviewed
Mar 23, 2017
| @@ -1,5 +1,6 @@ | |||
| class ManageIQ::Providers::Amazon::StorageManager::Ebs::CloudVolume < ::CloudVolume | |||
| supports :create | |||
| supports :snapshot_create | |||
There was a problem hiding this comment.
@gberginc do we miss the supports also for update and delete?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support in the backend was already there but the missing
supportsprevented UI from showing the corresponding menu item.
This screen shows the menu item for EBS volume
@miq-bot add_label bug