Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return instead of next is causing unwanted break of Vm parsing #202

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented Mar 28, 2017

Return instead of next is causing unwanted break of Vm parsing

Return instead of next is causing unwanted break of Vm parsing
@miq-bot
Copy link
Member

miq-bot commented Mar 28, 2017

Checked commit Ladas@ecea491 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍪

@Ladas Ladas added the fine/yes label Mar 29, 2017
@durandom durandom merged commit 9a1e300 into ManageIQ:master Mar 29, 2017
@durandom durandom added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 29, 2017
simaishi pushed a commit that referenced this pull request Mar 30, 2017
…sing_a_missing_vms

Return instead of next is causing unwanted break of Vm parsing
(cherry picked from commit 9a1e300)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit e204d9edb23a1bde81a7bc820f23d3910387ddb7
Author: Marcel Hild <hild@b4mad.net>
Date:   Wed Mar 29 10:58:28 2017 +0200

    Merge pull request #202 from Ladas/used_return_instead_of_next_is_causing_a_missing_vms
    
    Return instead of next is causing unwanted break of Vm parsing
    (cherry picked from commit 9a1e30037219cbb4d4db871bb012e0dd03f1a3d0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants