Make S3 a prototype feature

[blomquisg]

Add a configuration to the Settings.yml file that allows administrators to enable or disable Amazon S3 support.

The feature will be disabled by default.

Disabling S3 will disable the S3 manager, which will prevent the S3 refresh worker from starting.

[Ladas]

@blomquisg hm, this will prevent it from being created. Problem is that we can't add it then from the UI, so that is probably an RFE for later.

[blomquisg]

Looks like I have to add the Settings check to all of the tests, too...

[Ladas]

@blomquisg hm, you can probably just change the count of :ext_management_systems and only place where we need the setting enabled is https://github.com/Ladas/manageiq-providers-amazon/blob/05c2d067bbe36fba395211f5a9dd27bae7afdeec/spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb

[Ladas]

Looks great. @durandom just asked me to do the 0 defaults, so that is super cool it's already done :-)

[Ladas]

Actually, could you run rubocop -a on those spec files? And push it as a separate commit please.

[durandom]

note that settings will be merged with the core configs...
is there already a top level prototype key?
otherwise I'd put it underems -> ems_amazon -> s3_prototype e.g.

[blomquisg]

Yeah, there's already a prototype key in core settings.

[miq-bot]

Checked commits blomquisg/manageiq-providers-amazon@a419667~...0c2faca with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
9 files checked, 0 offenses detected
Everything looks good. 🍰

[blomquisg]

@Ladas cops updated, and tests passing.

[Ladas]

looks great now 👍

[simaishi]

Fine backport details:

$ git log -1
commit 0a8f3b8ac870a4c383a427d646975eb5ac672528
Author: Ladislav Smola <lsmola@redhat.com>
Date:   Tue Apr 25 13:04:41 2017 +0200

    Merge pull request #213 from blomquisg/amazon_s3_prototype
    
    Make S3 a prototype feature
    (cherry picked from commit 2b92588b6de01b14521ebb6d7b02f669feba82c1)