Do not downcase the amazon IAM username #296
Conversation
|
@gtanzillo and @abellotti please review |
|
@miq-bot add_labels authentication, bug |
|
@jvlcek Cannot apply the following label because they are not recognized: authentication |
|
Looks good @jvlcek, maybe just the .freeze to keep rubocop happy. Thanks !! |
|
Good point @abellotti. done.freeze :) |
|
@gtanzillo and @abellotti Thank you. I'll squash the commits. |
jvlcek
force-pushed
the
bz1489596_aws_userid_caps
branch
from
6bc7fb0
to
3a2408b
Compare
|
Checked commit jvlcek@3a2408b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot add_labels fine/yes |
|
@gtanzillo Can you please merge this? |
| @@ -141,5 +141,9 @@ def aws_connect(access_key_id, secret_access_key, service = :IAM, proxy_uri = ni | |||
| :log_formatter => Aws::Log::Formatter.new(Aws::Log::Formatter.default.pattern.chomp) | |||
| ) | |||
| end | |||
|
|
|||
| def normalize_username(username) | |||
| username | |||
There was a problem hiding this comment.
This seems really strange. I've looked at the base code and I understand why this is here.
It's just strange that the subclass has the "reset" the default behavior (i.e., doesn't downcase the username) because the base implementation changes the default behavior (i.e., downcases the username).
Oh well, just something to keep in mind if this comes back to bite.
(manually picked from ManageIQ/manageiq-providers-amazon@3a2408b) The code has been refactored on the master branch. It has been moved to the https://github.com/ManageIQ/manageiq-providers-amazon repository. The master PR for this change is: ManageIQ/manageiq-providers-amazon#296 This commit addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1489596
|
Backported to Fine via ManageIQ/manageiq#15959 |
(manually picked from ManageIQ/manageiq-providers-amazon@3a2408b) The code has been refactored on the master branch. It has been moved to the https://github.com/ManageIQ/manageiq-providers-amazon repository. The master PR for this change is: ManageIQ/manageiq-providers-amazon#296 This commit addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1489596
https://bugzilla.redhat.com/show_bug.cgi?id=1489596
Summary:
Fix authentication mode: amazon
Description:
This PR address a regression that was introduce by PR 15796 which
caused a regression in authentication preventing logins when the authentication
mode is configured for "Amazon"
Notes to QE on how to test this fix: