Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Tower in notifications for embedded ansible #10

Merged
merged 2 commits into from
Jul 17, 2017

Conversation

blomquisg
Copy link
Member

ManageIQ should not indicate that anything "Tower" exists when dealing
with Embedded Ansible. This should change the logs and notifications to
use a more "embedded ansibly" term when talking about embedded ansibly
things.

Before:

"The operation Ansible Tower Credential creation (name=...) on
Tower(manager_id=...) completed successfully."
^^^^^

After:

"The operation Ansible Automation Inside Credential creation (name=...)
on EMS(manager_id=1) completed successfully."
   ^^^

https://bugzilla.redhat.com/show_bug.cgi?id=1458593

see also: ManageIQ/manageiq#15478

@agrare
Copy link
Member

agrare commented Jun 29, 2017

@blomquisg can you update the spec tests to match the new notification string?

ManageIQ should not indicate that anything "Tower" exists when dealing
with Embedded Ansible.  This should change the logs and notifications to
use a more "embedded ansibly" term when talking about embedded ansibly
things.

Before:

  "The operation Ansible Tower Credential creation (name=...) on
  Tower(manager_id=...) completed successfully."
  ^^^^^

After:

  "The operation Ansible Automation Inside Credential creation (name=...)
  on EMS(manager_id=1) completed successfully."
     ^^^

https://bugzilla.redhat.com/show_bug.cgi?id=1458593
@miq-bot
Copy link
Member

miq-bot commented Jul 17, 2017

Checked commits blomquisg/manageiq-providers-ansible_tower@9683ab6~...bc16c7c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 🏆

@blomquisg
Copy link
Member Author

@agrare updated

@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

@blomquisg I assume this should be fine/yes?

@jameswnl
Copy link
Contributor

jameswnl commented Aug 4, 2017

@simaishi yes, this is.

@miq-bot add_label fine/yes

@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

Fine backport (to manageiq repo) details:

$ git log -1
commit 519584923ddcf622f5351730641773f0c20ad53b
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Jul 17 18:22:43 2017 -0400

    Merge pull request #10 from blomquisg/tower_not_tower
    
    Avoid Tower in notifications for embedded ansible
    (cherry picked from commit b9c12e84e9904c64c094067397ab2dad8b281f7d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1478429

@agrare agrare added this to the Sprint 65 Ending Jul 24, 2017 milestone Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants