Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrypt extra_vars before sending over to tower gem. #127

Merged

Conversation

lfu
Copy link
Member

@lfu lfu commented Sep 28, 2018

Need to decrypt extra_vars when ansible playbook service is called from automate embedded method.

Related to ManageIQ/manageiq-content#435.

https://bugzilla.redhat.com/show_bug.cgi?id=1602883

@miq-bot add_label bug, gaprindashvili/yes, hammer/yes

cc @gmcculloug @mkanoor

@miq-bot
Copy link
Member

miq-bot commented Sep 28, 2018

Checked commit lfu@45f6fe7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@gmcculloug gmcculloug self-assigned this Oct 1, 2018
@gmcculloug gmcculloug merged commit 0289814 into ManageIQ:master Oct 2, 2018
@gmcculloug gmcculloug added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 2, 2018
simaishi pushed a commit that referenced this pull request Oct 2, 2018
@simaishi
Copy link
Contributor

simaishi commented Oct 2, 2018

Hammer backport details:

$ git log -1
commit 73b132b92635abdf17d903edcc44e417cacbc810
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Tue Oct 2 08:25:35 2018 -0400

    Merge pull request #127 from lfu/encrypted_password_in_playbook_1602883
    
    Decrypt extra_vars before sending over to tower gem.
    
    (cherry picked from commit 028981410c8d7fb9b8109149c944b31fa665472b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1602883

@simaishi
Copy link
Contributor

simaishi commented Oct 3, 2018

As per BZ Target Release, removing gaprindashvili/yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants