find_by 'type' is a string, not a class #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
Oct 5, 2018
| @@ -152,14 +152,14 @@ def assert_credentials | |||
| expect(expected_configuration_script.authentications.count).to eq(3) | |||
|
|
|||
| # vault_credential | |||
| vault_credential = Authentication.all.find_by(:type => manager_class::VaultCredential, :manager_ref => '1022') | |||
| vault_credential = Authentication.all.find_by(:type => manager_class::VaultCredential.name, :manager_ref => '1022') | |||
There was a problem hiding this comment.
wow. 😖 . I'll fix that too
Fixes a rather non-obvious error on Rails 5.1:
TypeError:
can't cast Class
jrafanie
force-pushed
the
find_by_type_is_a_string
branch
from
746fef4
to
ea3ed40
Compare
|
Checked commit jrafanie@ea3ed40 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Oct 5, 2018
agrare
approved these changes
Oct 5, 2018
|
This was extracted from ManageIQ/manageiq#18076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rather non-obvious error on Rails 5.1: