Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if project_id is accessible #23

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

durandom
Copy link
Member

This is similar to ManageIQ/manageiq#14297
and it seems to be still the root cause here ansible/ansible_tower_client_ruby#68

@jameswnl Did we get to the root cause why this happens? Is it because of a mix of Ansible Tower v2 and v3 in the environment?

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1485414

@durandom durandom added the bug label Aug 29, 2017
@durandom durandom requested a review from jameswnl August 29, 2017 08:08
@miq-bot
Copy link
Member

miq-bot commented Sep 14, 2017

Checked commit durandom@a4ed443 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Contributor

@jameswnl jameswnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as best as we can get being limited by ansible/ansible_tower_client_ruby#68 (which may need a overhaul of the way the gem works)

@durandom
Copy link
Member Author

@bdunne you want to take a look?
imo this is an easy fix around ansible/ansible_tower_client_ruby#68

Dont know how far you've got to fix the initial problem in that issue. I still think we should not use the "related" array to create the _id methods

@miq-bot assign @bdunne

@durandom
Copy link
Member Author

@miq-bot add_label blocker

@bdunne can you have a look? This became a blocker

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also happen at different levels of the API, but either way, this is probably the best way to fix it.

@bdunne
Copy link
Member

bdunne commented Sep 25, 2017

@durandom can you add a "Fine" label?

@durandom
Copy link
Member Author

@bdunne label added - can you merge here?

@bdunne
Copy link
Member

bdunne commented Sep 25, 2017

Thanks, no I don't have merge rights here. Maybe @agrare

@agrare agrare merged commit 76a9b64 into ManageIQ:master Sep 25, 2017
@agrare agrare added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 25, 2017
@durandom durandom deleted the job_template_project_id branch September 26, 2017 12:14
@durandom
Copy link
Member Author

@simaishi
Copy link
Contributor

Fine backport (to manageiq repo) details:

$ git log -1
commit 047c3314e171fcf2aefa41fdb2f44a30f9e46db4
Author: Adam Grare <agrare@redhat.com>
Date:   Mon Sep 25 11:08:45 2017 -0400

    Merge pull request #23 from durandom/job_template_project_id
    
    check if project_id is accessible
    (cherry picked from commit 76a9b64616703033bf291bc640a7bcdd19226fb2)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1496929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants