Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tower Rhv credential type #62

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Tower Rhv credential type #62

merged 1 commit into from
Mar 13, 2018

Conversation

jameswnl
Copy link
Contributor

@jameswnl jameswnl changed the title Tower Rhv credential type [WIP] Tower Rhv credential type Feb 23, 2018
@miq-bot
Copy link
Member

miq-bot commented Feb 23, 2018

@jameswnl unrecognized command 'add_lables', ignoring...

Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

@jameswnl jameswnl mentioned this pull request Feb 23, 2018
Merged
@miq-bot miq-bot added the wip label Feb 23, 2018
@miq-bot
Copy link
Member

miq-bot commented Feb 23, 2018

Checked commit https://github.com/jameswnl/manageiq-providers-ansible_tower/commit/319daaccc5ca8bab7ede974c780ea458572f403f with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 1 offense detected

app/models/manageiq/providers/ansible_tower/shared/automation_manager/rhv_credential.rb

  • ❗ - Line 3, Col 5 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

@jameswnl jameswnl changed the title [WIP] Tower Rhv credential type Tower Rhv credential type Feb 26, 2018
@miq-bot miq-bot removed the wip label Feb 26, 2018
@jameswnl
Copy link
Contributor Author

@miq-bot remove_label wip
@miq-bot add_label enhancement

@jameswnl jameswnl mentioned this pull request Feb 26, 2018
Closed
21 tasks
@jameswnl
Copy link
Contributor Author

/cc @bronaghs @Glutexo

1 similar comment
@jameswnl
Copy link
Contributor Author

/cc @bronaghs @Glutexo

@agrare agrare self-assigned this Mar 13, 2018
@agrare agrare merged commit fdc757d into ManageIQ:master Mar 13, 2018
@agrare agrare added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 13, 2018
simaishi pushed a commit that referenced this pull request Mar 22, 2018
@agrare @simaishi
Merge pull request #62 from jameswnl/rhev
ee546a0 
Tower Rhv credential type
(cherry picked from commit fdc757d)

https://bugzilla.redhat.com/show_bug.cgi?id=1559479
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit ee546a0b729c6167fa46df9b5496f55f4ed181f0
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Mar 13 09:01:01 2018 -0400

    Merge pull request #62 from jameswnl/rhev
    
    Tower Rhv credential type
    (cherry picked from commit fdc757d48f258876a28d38cfd6872e8ae6d8543f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1559479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jameswnl @miq-bot @simaishi @agrare @gmcculloug @mimodian