Populate project without update job in Tower #82

Glutexo · 2018-05-10T12:48:36Z

Spec examples introduced by #72 require one project with an update job and another without one. Use another_repo for the latter case. Alter the populate_tower Rake task to delete the update job after the initial update finishes.

Merging this PR does not make sense before merging other PRs:

specs in Get stdout on ansible repository refresh #72 need a project without an update job

@miq-bot add_reviewer @jameswnl

miq-bot · 2018-05-31T15:40:54Z

This pull request is not mergeable. Please rebase and repush.

Glutexo · 2018-06-05T09:58:42Z

Rebased on current state of #72.

Glutexo · 2018-06-07T08:07:44Z

@miq-bot add_label unmergeable

Glutexo · 2018-06-07T08:53:34Z

@miq-bot add_label pending core

jameswnl

Please rip out the duplicated changes with your other PR(s)

miq-bot · 2018-06-07T15:30:33Z

This pull request is not mergeable. Please rebase and repush.

Glutexo · 2018-06-08T10:58:10Z

I rebased to the current master, so it doesn’t contain any duplicate commits. Still I’d like to note that this PR introduces changes that are only useful after #72 gets into master. Merging this PR without #72 doesn’t make much sense.

Is there maybe some label, better that unmergeable to stick to such PRs?

* Create a failed_repo to test saving last update stdout. * Create a jobless_repo to test behavior of loading a project without an update job. Delete the job after it finishes upon project creation.

Glutexo · 2018-06-21T10:20:06Z

The last update job is used to capture its stdout. This output is now stored only if the update fails. [1], [2] To test this, we need more than one project: 3

A project with successful update.
A project with failed update.
A project without update.

Updated the Rake task to create those projects. Removed another_repo, any of the new ones (jobless_repo or failed_repo) can be used instead by #93 and #92.

@jameswnl might want to review this change.

tumido

I'd like to see @jameswnl 's approval on this. Otherwise my only concern are the messy Hashes, which seems to me rather unreadible than anything else. I'll take it over this PR and update it.

tumido · 2018-06-25T13:21:51Z

lib/tasks_private/spec_helper.rake


    # create a job_template
    uri = '/api/v1/job_templates/'
-    data = {"name" => 'hello_template', "description" => "test job", "job_type" => "run", "project" => project['id'], "playbook" => "hello_world.yml", "credential" => machine_credential['id'], "cloud_credential" => aws_credential['id'], "network_credential" => network_credential['id'], "inventory" => inventory['id'], "organization" => organization['id']}
+    data = {"name" => 'hello_template', "description" => "test job", "job_type" => "run", "project" => hello_project['id'], "playbook" => "hello_world.yml", "credential" => machine_credential['id'], "cloud_credential" => aws_credential['id'], "network_credential" => network_credential['id'], "inventory" => inventory['id'], "organization" => organization['id']}


I'll try to convert this into proper Ruby hashes. It still gets serialized as JSON on send so, I don't see a reason why to keep it messy.

tumido

I did a cleanup on that file, it was painful to read it. I know that's not the point of this PR, though I had to do it...

tumido · 2018-06-26T13:52:37Z

The other PR #72 marked as "merge before" doesn't necessarily block this one. The dependency is rather a use-case for the environment prepared by this PR. We shouldn't need to wait.

tumido

🎆 🎊 🎸 🌈

miq-bot · 2018-06-26T15:24:31Z

Some comments on commits Glutexo/manageiq-providers-ansible_tower@361bff5~...49e4ace

lib/tasks_private/spec_helper.rake

⚠️ - 397 - Detected puts. Remove all debugging statements.
⚠️ - 408 - Detected puts. Remove all debugging statements.
⚠️ - 81 - Detected puts. Remove all debugging statements.
⚠️ - 90 - Detected puts. Remove all debugging statements.

miq-bot · 2018-06-26T15:24:37Z

Checked commits Glutexo/manageiq-providers-ansible_tower@361bff5~...49e4ace with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

Fryguy · 2018-06-27T17:41:21Z

In the future, please keep unrelated rubocop changes to a separate PR.

tumido · 2018-06-28T10:06:09Z

I know. We had a discussion about that here a4fe4a1#commitcomment-29502367 so we decided to keep it this way...

tumido · 2018-07-19T13:36:51Z

@jameswnl, can you review this once more, please? Are there any concerns which should be addressed?

miq-bot requested a review from jameswnl May 10, 2018 12:51

Glutexo mentioned this pull request May 10, 2018

Fetch, store and display stdout capture of an Ansible Tower project update job ManageIQ/manageiq#17307

Closed

14 tasks

Glutexo force-pushed the populate_project_without_update_job branch 2 times, most recently from 032ecb3 to d8a88b9 Compare May 24, 2018 14:04

Glutexo changed the title ~~Populate project without update job in Tower~~ [wip] Populate project without update job in Tower May 29, 2018

miq-bot added the wip label May 29, 2018

miq-bot added the unmergeable label May 31, 2018

Glutexo changed the title ~~[wip] Populate project without update job in Tower~~ Populate project without update job in Tower Jun 4, 2018

miq-bot removed the wip label Jun 4, 2018

Glutexo force-pushed the populate_project_without_update_job branch from d8a88b9 to 9aff831 Compare June 5, 2018 09:58

miq-bot removed the unmergeable label Jun 6, 2018

miq-bot added the unmergeable label Jun 7, 2018

miq-bot added the pending core label Jun 7, 2018

jameswnl closed this Jun 7, 2018

jameswnl reopened this Jun 7, 2018

jameswnl suggested changes Jun 7, 2018

View reviewed changes

Glutexo force-pushed the populate_project_without_update_job branch 2 times, most recently from 76a20e0 to 8baf65c Compare June 8, 2018 10:52

miq-bot removed the unmergeable label Jun 12, 2018

Create repos with different states

361bff5

* Create a failed_repo to test saving last update stdout. * Create a jobless_repo to test behavior of loading a project without an update job. Delete the job after it finishes upon project creation.

Glutexo force-pushed the populate_project_without_update_job branch from 8baf65c to 361bff5 Compare June 21, 2018 10:06

bronaghs assigned tumido Jun 21, 2018

tumido suggested changes Jun 25, 2018

View reviewed changes

tumido reviewed Jun 26, 2018

View reviewed changes

Clean up messy spec-helper.rake

49e4ace

tumido force-pushed the populate_project_without_update_job branch from a4fe4a1 to 49e4ace Compare June 26, 2018 15:18

tumido approved these changes Jun 26, 2018

View reviewed changes

tumido mentioned this pull request Jul 19, 2018

Collect variable Tower data upon population #92

Merged

jameswnl approved these changes Jul 20, 2018

View reviewed changes

jameswnl merged commit bff407a into ManageIQ:master Jul 20, 2018

bronaghs added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Populate project without update job in Tower #82

Populate project without update job in Tower #82

Glutexo commented May 10, 2018 •

edited

Loading

miq-bot commented May 31, 2018

Glutexo commented Jun 5, 2018

Glutexo commented Jun 7, 2018

Glutexo commented Jun 7, 2018

jameswnl left a comment

miq-bot commented Jun 7, 2018

Glutexo commented Jun 8, 2018 •

edited

Loading

Glutexo commented Jun 21, 2018 •

edited

Loading

tumido left a comment

tumido Jun 25, 2018

tumido left a comment •

edited

Loading

tumido commented Jun 26, 2018

tumido left a comment

miq-bot commented Jun 26, 2018

miq-bot commented Jun 26, 2018

Fryguy commented Jun 27, 2018

tumido commented Jun 28, 2018

tumido commented Jul 19, 2018

Populate project without update job in Tower #82

Populate project without update job in Tower #82

Conversation

Glutexo commented May 10, 2018 • edited Loading

miq-bot commented May 31, 2018

Glutexo commented Jun 5, 2018

Glutexo commented Jun 7, 2018

Glutexo commented Jun 7, 2018

jameswnl left a comment

Choose a reason for hiding this comment

miq-bot commented Jun 7, 2018

Glutexo commented Jun 8, 2018 • edited Loading

Glutexo commented Jun 21, 2018 • edited Loading

tumido left a comment

Choose a reason for hiding this comment

tumido Jun 25, 2018

Choose a reason for hiding this comment

tumido left a comment • edited Loading

Choose a reason for hiding this comment

tumido commented Jun 26, 2018

tumido left a comment

Choose a reason for hiding this comment

miq-bot commented Jun 26, 2018

miq-bot commented Jun 26, 2018

Fryguy commented Jun 27, 2018

tumido commented Jun 28, 2018

tumido commented Jul 19, 2018

Glutexo commented May 10, 2018 •

edited

Loading

Glutexo commented Jun 8, 2018 •

edited

Loading

Glutexo commented Jun 21, 2018 •

edited

Loading

tumido left a comment •

edited

Loading