Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for project update to finish #89

Merged

Conversation

Glutexo
Copy link
Member

@Glutexo Glutexo commented May 24, 2018

It may not be possible to create a job template right after creating a project that the template uses. Add a try-wait loop that ensures that the project has been created in Tower and it successfully finished
cloning.

Extracted from #73 for the changes to be more atomic.

@miq-bot add_reviewer @jameswnl

It may not be possible to create a job template right after creating a
project that the template uses. Add a try-wait loop that ensures that
the project has been created in Tower and it successfully finished
cloning.

In case of clone failure, raise an error. If the project is not ready
yet, wait a bit and try again. The number of tries is limited, raising
an error on depletion.
@miq-bot miq-bot requested a review from jameswnl May 24, 2018 10:26
@miq-bot
Copy link
Member

miq-bot commented May 24, 2018

Checked commit Glutexo@4311c0e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@jameswnl jameswnl merged commit e8780f2 into ManageIQ:master Jun 4, 2018
@Glutexo Glutexo deleted the wait_for_project_update_in_rake_task branch June 5, 2018 10:41
@agrare agrare added this to the Sprint 87 Ending Jun 4, 2018 milestone Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants