Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume NIC IP configuration has subnet #132

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Don't assume NIC IP configuration has subnet #132

merged 1 commit into from
Sep 25, 2017

Conversation

djberg96
Copy link
Collaborator

@djberg96 djberg96 commented Sep 22, 2017

Not all IP configurations for all NIC's will have a subnet. If it doesn't, the refresh parser for the NetworkManager will break. This fixes that.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1494143

@miq-bot
Copy link
Member

miq-bot commented Sep 22, 2017

Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/07ff99f9a8cec7d608f5de9d0d471233a1afdba8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@bronaghs bronaghs merged commit 4fef0d8 into ManageIQ:master Sep 25, 2017
@bronaghs bronaghs added this to the Sprint 70 Ending Oct 2, 2017 milestone Sep 25, 2017
simaishi pushed a commit that referenced this pull request Nov 10, 2017
Don't assume NIC IP configuration has subnet
(cherry picked from commit 4fef0d8)

https://bugzilla.redhat.com/show_bug.cgi?id=1496931
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit c9dab7134019cd139749816119b09e5c3e08ba27
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Mon Sep 25 09:38:45 2017 -0400

    Merge pull request #132 from djberg96/nic_subnets
    
    Don't assume NIC IP configuration has subnet
    (cherry picked from commit 4fef0d85222c284a68c29a024e770e4ff1f3f960)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1496931

@djberg96
Copy link
Collaborator Author

djberg96 commented Dec 5, 2017

@simaishi Needs a Euwe backport, too, please.

@simaishi
Copy link
Contributor

simaishi commented Dec 5, 2017

@djberg96 I need to check if this is a blocker for the upcoming Euwe release or not, as this wasn't on the blocker list and I can only backport for approved blockers.

@simaishi
Copy link
Contributor

simaishi commented Feb 6, 2018

Euwe backport (to manageiq repo) details:

$ git log -1
commit 656a62e790184bddc4213a7dd9247e67da81b1ec
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Mon Sep 25 09:38:45 2017 -0400

    Merge pull request #132 from djberg96/nic_subnets
    
    Don't assume NIC IP configuration has subnet
    (cherry picked from commit 4fef0d85222c284a68c29a024e770e4ff1f3f960)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1468604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants