Pass manageiq-smartstate the Resource Group Name not the Object #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label gaprindashvili/yes |
|
@miq-bot add_label fine/no |
|
@miq-bot add_label bug |
|
This pull request is not mergeable. Please rebase and repush. |
A previous fix that was backported to the FINE branch fixed this issue caused by the resource group being changed from a string to an object a while ago but the fix never went into the MASTER branch. This will fix in Master and should be back-ported to Gaprindashvili
jerryk55
force-pushed
the
another_resource_group_name_fix
branch
from
3057c7e
to
d71660f
Compare
|
Checked commit jerryk55@d71660f with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM 👍 |
bronaghs
approved these changes
Nov 6, 2017
simaishi
pushed a commit
that referenced
this pull request
Nov 7, 2017
Pass manageiq-smartstate the Resource Group Name not the Object (cherry picked from commit b0271f2) https://bugzilla.redhat.com/show_bug.cgi?id=1510072
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous fix that was backported to the FINE branch fixed this
issue caused by the resource group being changed from a string
to an object a while ago but the fix never went into the
MASTER branch. This will fix in Master and should be back-ported
to Gaprindashvili. It should not go into the FINE branch.
https://bugzilla.redhat.com/show_bug.cgi?id=1507977 is the bug for this PR.
@roliveri @hsong-rh @bronaghs @djberg96 please review and merge.