Move from MIQ repo to provider repo. #16
Conversation
|
@djberg96 oh, I have zero knowledge about those product files :( |
|
These files get seeded in the database from [app/models/miq_dialog.rb] (https://github.com/ManageIQ/manageiq/blob/28ea1414befb2aee4152dba397d04250b93b6bfd/app/models/miq_dialog.rb#L16). Have we updated any seeding methods to deal with pluggable providers? Is there a pattern for this yet? |
Seeding as in EvmDatabase.seed just works ™️ because of descendent_loader. For loading files, we havent moved anything yet 😢 @bdunne am I right, that once ManageIQ/manageiq#11083 is merged this could act as a model for seeding dialogs as well? |
|
@durandom That's a different seed for the dialogs. Check out MiqDialog.seed. |
Oh, I meant to act as a role model, like a pattern for doing this kind of file seeding. |
durandom
changed the title
|
Added [WIP] as we dont have a way of seeding dialogs yet |
|
@durandom ManageIQ/manageiq#11083 was merged. Should we revisit? |
|
@djberg96 I think the dialog files should live under |
There was a problem hiding this comment.
@djberg96 can you squash into one single commit and create a corresponding PR on core?
once ManageIQ/manageiq#14653 is merged we can merge
djberg96
changed the title
Update with changes from master. Updated to current master. Move file to content directory.
|
Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/cd5687537c429c0844c36f555c07ab997fa83efc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Just moving this over to our provider-specific repo.
@durandom Is there anything else that needs to happen for this to be picked up?