Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass resource group as a string to power operation methods #160

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Pass resource group as a string to power operation methods #160

merged 1 commit into from
Nov 6, 2017

Conversation

juliancheal
Copy link
Member

@juliancheal juliancheal commented Nov 6, 2017 •
edited by bronaghs
Loading

@miq-bot
Copy link
Member

miq-bot commented Nov 6, 2017

Checked commit https://github.com/juliancheal/manageiq-providers-azure/commit/738caf13bf743035e2d5806e451ce4a6383beab9 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@bronaghs bronaghs merged commit dbb5d39 into ManageIQ:master Nov 6, 2017
@bronaghs bronaghs added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 6, 2017
@bronaghs
Copy link

bronaghs commented Nov 6, 2017

FYI I inserted the full BZ link into the PR description so the bot could update the BZ with the commit information

@juliancheal
Copy link
Member Author

FYI I inserted the full BZ link into the PR description so the bot could update the BZ with the commit information

Ah, I had the bz number in the commit, didn't realise it needed to be in the PR description, thanks.

@bronaghs bronaghs added the bug label Nov 6, 2017
simaishi pushed a commit that referenced this pull request Nov 6, 2017
@simaishi
Merge pull request #160 from juliancheal/bz-1509275-azure_power_options
7314a93 
Pass resource group as a string to power operation methods
(cherry picked from commit dbb5d39)

https://bugzilla.redhat.com/show_bug.cgi?id=1510201
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit 7314a93e3b414e63eb549206b7b4564625d1ac18
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Mon Nov 6 14:14:53 2017 -0500

    Merge pull request #160 from juliancheal/bz-1509275-azure_power_options
    
    Pass resource group as a string to power operation methods
    (cherry picked from commit dbb5d39fe0b280b75e7b06d093b11ef6c0d42207)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1510201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bronaghs bronaghs bronaghs approved these changes

Assignees
No one assigned
Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliancheal @miq-bot @bronaghs @simaishi