Only create new Public IP if one cannot be found

[djberg96]

At the moment, if you select a public IP address when provisioning, but that IP is not currently associated with a NIC, it will create a new IP instead of using the one selected.

This PR modifies the provisioning code so that when a new NIC is provisioned, it will attempt to use the selected public IP before resorting to creating a new one.

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1531099

[bronaghs]

Looks good @djberg96
Is there a spec that can be added?

[bronaghs]

as mentioned inline, looks like a spec can be added for this.

[djberg96]

@bronaghs I think I would have to create a new spec file, since provision_spec.rb stubs out the response for create_nic. I noticed that there's no provision/cloning_spec.rb, so I'll have to add one, which will take some time.

[bronaghs]

I am wondering if you can update provision_spec.rb to stub out NetworkInterfaceService and IpAddressService within the create_nic method?

[djberg96]

@bronaghs well, i'm not really testing the overall provisioning, just the method itself. Creating a separate spec file for cloning.rb would probably boost our coverage a bit, too.

[miq-bot]

Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/ac78d353f62fbb8d8ec615484854773ddf77f972 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[djberg96]

@bronaghs I've added some specs. I created a separate cloning_spec.rb file that just tests the Cloning module methods in isolation instead of adding more provisioning specs since that's really the behavior we care about in this instance.

[simaishi]

gaprindashvili/yes ?

[djberg96]

Well, target release was 5.9, but it should be ok. @bronaghs ?

Nevermind, set tag.

[simaishi]

gaprindashvili is 5.9!

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 7247d28184cefbdb498228574abaa4e1928af72d
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Fri Jan 26 12:40:49 2018 -0500

    Merge pull request #195 from djberg96/auto_provision_nic
    
    Only create new Public IP if one cannot be found
    (cherry picked from commit d4ac3bfb134aeaa1313a44e80299199e58cee230)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1566577