Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat securestring case insentive #206

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Treat securestring case insentive #206

merged 1 commit into from
Feb 12, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented Feb 9, 2018 •
edited
Loading

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1543629

The dialog tool treats parameter type securestring as password field, but should accept the type key case insensitive.

@bzwei
Copy link
Contributor Author

bzwei commented Feb 9, 2018

@miq-bot add_label bug, gaprindashvili/yes
@miq-bot assign @bronaghs
cc @gmcculloug

@gmcculloug
Copy link
Member

@bzwei Please address rubocop warning.

@d-m-u Please help look into why the tests from your recent PR #199 are failing here?

@miq-bot
Copy link
Member

miq-bot commented Feb 9, 2018

Checked commit bzwei@4fe6037 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@d-m-u
Copy link
Contributor

d-m-u commented Feb 9, 2018

@bzwei @gmcculloug the run that was green didn't finish, it only ran 120/136 tests :( Will open PR to fix failure, should've failed originally

gmcculloug
gmcculloug approved these changes Feb 10, 2018
View reviewed changes
Copy link
Member

@gmcculloug gmcculloug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Failing test is unrelated fix in PR #207

@gmcculloug gmcculloug merged commit 05206d8 into ManageIQ:master Feb 12, 2018
@gmcculloug gmcculloug added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 12, 2018
simaishi pushed a commit that referenced this pull request Mar 6, 2018
@gmcculloug @simaishi
Merge pull request #206 from bzwei/secure_string
3700748 
Treat securestring case insentive
(cherry picked from commit 05206d8)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552301
@simaishi
Copy link
Contributor

simaishi commented Mar 6, 2018

Gaprindashvili backport details:

$ git log -1
commit 3700748d2a1a7892bf2b910769cbbc63102af840
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon Feb 12 09:35:05 2018 -0500

    Merge pull request #206 from bzwei/secure_string
    
    Treat securestring case insentive
    (cherry picked from commit 05206d8c96ba3bffb9bb3b2a527daacc41821ed7)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1552301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcculloug gmcculloug gmcculloug approved these changes

Assignees

@bronaghs bronaghs

Labels
bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzwei @gmcculloug @miq-bot @d-m-u @simaishi @bronaghs