Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case-sensitive events ems_ref parsing #225

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Fix case-sensitive events ems_ref parsing #225

merged 1 commit into from
Mar 19, 2018

Conversation

tumido
Copy link
Member

@tumido tumido commented Mar 16, 2018 •
edited
Loading

Normalize ems_ref for:

  • :floating_ips (publicIPAddresses is correct)
  • :cloud_networks (virtualNetworks is correct, strip subnet related details)
  • :security_groups (remove security rules related parts, leave parent security group only)

Specs are consolidated, so despite different case of letters inside the event JSON, the ems_ref remains consistent.

Related to: #222
Part of fix for https://bugzilla.redhat.com/show_bug.cgi?id=1487602

@tumido
Copy link
Member Author

tumido commented Mar 16, 2018

@miq-bot add_label bug, events

@miq-bot
Copy link
Member

miq-bot commented Mar 16, 2018

Checked commit tumido@af4f8f4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@djberg96 djberg96 requested a review from Ladas March 16, 2018 16:22
Ladas
Ladas approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@Ladas Ladas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome

@bronaghs bronaghs merged commit 6766b67 into ManageIQ:master Mar 19, 2018
@bronaghs bronaghs added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 19, 2018
simaishi pushed a commit that referenced this pull request Mar 22, 2018
@simaishi
Merge pull request #225 from tumido/azure_events_targeted
d7dbeec 
Fix case-sensitive events ems_ref parsing
(cherry picked from commit 6766b67)

https://bugzilla.redhat.com/show_bug.cgi?id=1558078
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit d7dbeec01b3dfce5993297395255e8d4fd54719f
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Mon Mar 19 06:31:07 2018 -0400

    Merge pull request #225 from tumido/azure_events_targeted
    
    Fix case-sensitive events ems_ref parsing
    (cherry picked from commit 6766b671c6d57b3c70e79752bafad7693f05de37)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1558078

@tumido tumido deleted the azure_events_targeted branch June 26, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bronaghs bronaghs bronaghs approved these changes

@Ladas Ladas Ladas approved these changes

Assignees
No one assigned
Labels
bug events gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tumido @miq-bot @simaishi @Ladas @bronaghs