Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle possibility of network_port not having private_ip_address #85

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Handle possibility of network_port not having private_ip_address #85

merged 1 commit into from
Jun 27, 2017

Conversation

djberg96
Copy link
Collaborator

Addresses an issue where not every IP configuration has a private_ip_address property. We already guard against this possibility in the cloud manager, but apparently missed it in the network manager.

Addresses #82

@djberg96 djberg96 requested a review from bronaghs June 25, 2017 15:35
@miq-bot
Copy link
Member

miq-bot commented Jun 25, 2017

Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/3d44446ecf4e8fc37fec7715f0266b161a3f93e1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@djberg96
Copy link
Collaborator Author

@miq-bot add_label fine/yes

@djberg96
Copy link
Collaborator Author

@miq-bot add_label euwe/yes

@bzwei
Copy link
Contributor

bzwei commented Jun 26, 2017

LGTM

@bronaghs bronaghs merged commit cb44c13 into ManageIQ:master Jun 27, 2017
@bronaghs bronaghs added this to the Sprint 64 Ending Jul 3, 2017 milestone Jun 27, 2017
@simaishi
Copy link
Contributor

@djberg96 Is there a BZ for this? Can you please create if it doesn't exist?

@djberg96
Copy link
Collaborator Author

djberg96 commented Jul 3, 2017

@simaishi
Copy link
Contributor

simaishi commented Jul 7, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit 6b79018770d0fa27b3cf4c5d79f4adac6606af07
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Tue Jun 27 09:38:26 2017 -0400

    Merge pull request #85 from djberg96/private_ip
    
    Handle possibility of network_port not having private_ip_address
    (cherry picked from commit cb44c138c3496d5cc7326dc4df923c10969e170e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1468604

simaishi pushed a commit that referenced this pull request Jul 7, 2017
Handle possibility of network_port not having private_ip_address
(cherry picked from commit cb44c13)

https://bugzilla.redhat.com/show_bug.cgi?id=1468700
@simaishi
Copy link
Contributor

simaishi commented Jul 7, 2017

Fine backport details:

$ git log -1
commit 352f7052bddc3c66651ad772e478e8eb0175e811
Author: Bronagh Sorota <bsorota@redhat.com>
Date:   Tue Jun 27 09:38:26 2017 -0400

    Merge pull request #85 from djberg96/private_ip
    
    Handle possibility of network_port not having private_ip_address
    (cherry picked from commit cb44c138c3496d5cc7326dc4df923c10969e170e)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1468700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants