Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse requests and limits for Persistent Volume Claim #116

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Parse requests and limits for Persistent Volume Claim #116

merged 1 commit into from
Nov 15, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Sep 24, 2017 •
edited by moolitayer
Loading

@zakiva zakiva mentioned this pull request Sep 24, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Sep 24, 2017

Checked commit zakiva@6e7c28f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@moolitayer moolitayer requested a review from zeari October 30, 2017 09:48
moolitayer
moolitayer approved these changes Oct 30, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moolitayer
Copy link

re kicking Travis

@moolitayer moolitayer closed this Oct 31, 2017
@moolitayer moolitayer reopened this Oct 31, 2017
@moolitayer
Copy link

@zakiva is this targeted for Gaprindashvili? if so we will need a label and a bug

@zakiva
Copy link
Contributor Author

zakiva commented Nov 1, 2017

@zakiva is this targeted for Gaprindashvili? if so we will need a label and a bug

Yes, I opened a BZ and added it in the description above.

@zakiva
Copy link
Contributor Author

zakiva commented Nov 1, 2017

@miq-bot add_label gaprindashvili/yes

@moolitayer
Copy link

Kicking Travis

@moolitayer moolitayer closed this Nov 14, 2017
@moolitayer moolitayer reopened this Nov 14, 2017
@moolitayer moolitayer merged commit e3a711a into ManageIQ:master Nov 15, 2017
@moolitayer moolitayer added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 15, 2017
@moolitayer
Copy link

moolitayer commented Nov 15, 2017 •
edited
Loading

I'm Removing the Gaprindashvili tag. The Schema PR ins't in Gaprindashvili and I see no Ticket targeted for it.
@miq-bot remove_label gaprindashvili/yes
@miq-bot add_label gaprindashvili/no

@moolitayer
Copy link

My Mistake, ManageIQ/manageiq-schema#74 is in G.

simaishi pushed a commit that referenced this pull request Nov 15, 2017
@simaishi
Merge pull request #116 from zakiva/claim_requests_and_limits
2fc6bf6 
Parse requests and limits for Persistent Volume Claim
(cherry picked from commit e3a711a)

https://bugzilla.redhat.com/show_bug.cgi?id=1513482
@simaishi
Copy link

Gaprindashvili backport details:

$ git log -1
commit 2fc6bf604b1afc439f32c2728dc2b063bf7787a7
Author: Mooli Tayer <mtayer@redhat.com>
Date:   Wed Nov 15 12:16:32 2017 +0200

    Merge pull request #116 from zakiva/claim_requests_and_limits
    
    Parse requests and limits for Persistent Volume Claim
    (cherry picked from commit e3a711af542f8ba68373e3cd5e2e17198c1b3f51)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1513482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moolitayer moolitayer moolitayer approved these changes

@zeari zeari zeari approved these changes

Assignees

@moolitayer moolitayer

Labels
enhancement gaprindashvili/backported inventory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zakiva @miq-bot @moolitayer @simaishi @zeari