Support KubeVirt provider

[masayag]

The kubevirt provider will be managed as a virtualization manager under
the container managers.

The endpoint and authentication of kubevirt will be selected by
:kubevirt role and authkey.

This PR depends on ManageIQ/manageiq#16721.

Additional related PRs:

UI PR:
ManageIQ/manageiq-ui-classic#3143

kubevirt provider PR:
ManageIQ/manageiq-providers-kubevirt#6

[masayag]

@miq-bot add_labels enhancement, gaprindashvili/no

[moolitayer]

I can't seem to find where this is used?
(except for this)

[masayag]

It is used in the kubevirt provider repo: https://github.com/ManageIQ/manageiq-providers-kubevirt/pull/6/files#diff-ff17b05a7c525eec833f0ddb0134a0d9R26

[masayag]

@moolitayer I've updated the PR message to reference the other related PRs (ui-classic and kubevirt provider)

[moolitayer]

@cben @zeari need your review on this one

[masayag]

@moolitayer I need to update the current version of the PR. Will nag when ready for review.

[moolitayer]

@moolitayer I need to update the current version of the PR. Will nag when ready for review.

thanks

[masayag]

@zeari @moolitayer this specific test fails with:

/home/masayag/work/manageiq-master/app/models/ext_management_system.rb:95:in hostname_format_valid?'
...
# /home/masayag/.rvm/gems/ruby-2.3.3/gems/activerecord-5.0.6/lib/active_record/suppressor.rb:41:in save' # /home/masayag/work/manageiq-master/app/models/mixins/has_virtualization_manager_mixin.rb:8:in virtualization_endpoint_created'
# /home/masayag/work/manageiq-master/app/models/manageiq/providers/container_manager.rb:104:in endpoint_created' # /home/masayag/work/manageiq-master/app/models/endpoint.rb:17:in endpoint_created'

It appears that even though the endpoint_created was called twice (for 'default' and 'kubevirt'), before saving the virtualization manager, there is 'default' endpoint.

Any ideas ?

[moolitayer]

There is an error related to the validity of the hostname?

[zeari]

Try

it "Creates a virtualization manager when container manager is updated with a kubevirt endpoint" do
  ems = FactoryGirl.create(:ems_kubernetes, :endpoints => [FactoryGirl.build(:endpoint, :role => 'default', :hostname => 'iamahostname'])
  kubevirt_endpoint = FactoryGirl.create(:endpoint, :role => 'kubevirt', :hostname => 'host', :resource => ems)
   # ems.endpoints << kubevirt_endpoint  ----- you dont need this because of :resource => ems
  expect(ems.virtualization_manager).not_to be_nil
  expect(ems.virtualization_manager.parent_manager).to eq(ems)
  expect(ems.virtualization_manager.default_endpoint.role).to eq("kubevirt")
end

[masayag]

@zeari that didn't do the trick.

I ended up with creating an endpoint (via FactoryGirl.build) and in the next line added it to the ems.endpoints

That seems to satisfy the spec.

[miq-bot]

Checked commit masayag@c16eb0d with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

app/models/manageiq/providers/kubernetes/container_manager_mixin.rb

• ❗ - Line 183, Col 5 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

[masayag]

@zeari I've updated the PR according to Adam's comments on the core PR (renamed the virtualization_manger to infra_manager).

[agrare]

@masayag looks like some valid test failures

[agrare]

Travis isn't running and the test suite passes locally, just going to merge this to fix the errors on master