-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip hostname validation for virtualization manager #245
Conversation
When adding kubevirt provider with container provider at the same request, there is no 'default' endpoint if the kubevirt provider is added first. Therefore no need to check for hostname validation at that point of time.
Verified by:
Which returned:
While the same script fails without this PR with: |
@moolitayer @zeari please review. |
Checked commit masayag@d71d556 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
When adding kubevirt provider with container provider at the same
request, there is no 'default' endpoint if the kubevirt provider is
added first. Therefore no need to check for hostname validation at that
point of time.