Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec assuming default zone #297

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

agrare
Copy link
Member

@agrare agrare commented Oct 23, 2018

This container scan test was assuming the EMS was put in the default
zone when checking the zone name.

The behavior of the default ext_management_system factory was changed here ManageIQ/manageiq#18118

This container scan test was assuming the EMS was put in the default
zone when checking the zone name.
@agrare
Copy link
Member Author

agrare commented Oct 23, 2018

cc @Ladas

@miq-bot
Copy link
Member

miq-bot commented Oct 23, 2018

Checked commit agrare@905845b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@cben cben added this to the Sprint 98 Ending Nov 5, 2018 milestone Oct 24, 2018
@cben cben self-assigned this Oct 24, 2018
@cben cben merged commit 296f4ad into ManageIQ:master Oct 24, 2018
@agrare agrare deleted the fix_test_assuming_default_zone branch October 24, 2018 12:43
cben added a commit to cben/manageiq-providers-kubernetes that referenced this pull request Nov 1, 2018
cben added a commit to cben/manageiq-providers-kubernetes that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants