Separate OSV and Kubevirt virtualization options from form #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
agrare
reviewed
Aug 15, 2024
| @@ -544,6 +534,20 @@ def self.params_for_create | |||
| } | |||
| end | |||
|
|
|||
| def virtualization_options | |||
There was a problem hiding this comment.
.params_for_create is a class method so this has to be also
Suggested change
| def virtualization_options | |
| def self.virtualization_options |
nasark
force-pushed
the
subclass_osv_kubevirt
branch
from
410f788
to
3c1a488
Compare
|
Checked commit nasark@3c1a488 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
nasark
changed the title
agrare
approved these changes
Aug 29, 2024
agrare
approved these changes
Sep 10, 2024
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Oct 8, 2024
Separate OSV and Kubevirt virtualization options from form (cherry picked from commit c73a5bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment ManageIQ/manageiq-providers-openshift#264 (comment)
Depends on:
@miq-bot assign @agrare
@miq-bot add_label enhancement
@miq-bot add_reviewer @agrare