Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for onboard network devices #105

Merged

Conversation

skovic
Copy link

@skovic skovic commented Nov 2, 2017

This PR updates the refresh parser to support onboard network devices. In addition, guest_device related methods in the refresh parser were refactored, so future support for expansion cards will be easier to implement.

@miq-bot
Copy link
Member

miq-bot commented Nov 2, 2017

Checked commit skovic@d5e6975 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 3 offenses detected

app/models/manageiq/providers/lenovo/physical_infra_manager/refresh_parser.rb

@skovic
Copy link
Author

skovic commented Nov 2, 2017

@miq-bot add_label gaprindashvili/yes

@skovic
Copy link
Author

skovic commented Nov 2, 2017

@miq-bot assign @rodneyhbrown7

@rodneyhbrown7
Copy link
Contributor

LGTM. Note that a PR is needed in the UI to change the "Network Adapters" table to "Network Devices"

@rodneyhbrown7 rodneyhbrown7 merged commit 6ce24af into ManageIQ:master Nov 3, 2017
simaishi pushed a commit that referenced this pull request Nov 6, 2017
Add support for onboard network devices
(cherry picked from commit 6ce24af)
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit c26fcbb20647948ee15c6f8a06213d270689d98c
Author: Rodney Brown <rodneyhbrown7@users.noreply.github.com>
Date:   Fri Nov 3 10:14:44 2017 -0400

    Merge pull request #105 from skovic/onboard-network-device-support
    
    Add support for onboard network devices
    (cherry picked from commit 6ce24afafe0df3c337bc9db56c6c84f71da84310)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants