Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssetDetails should be AssetDetail #125

Merged
merged 1 commit into from
Feb 16, 2018
Merged

AssetDetails should be AssetDetail #125

merged 1 commit into from
Feb 16, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jan 17, 2018 •
edited
Loading

@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2018

Checked commit bdunne@34e13f9 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

rodneyhbrown7
rodneyhbrown7 approved these changes Jan 18, 2018
View reviewed changes
Copy link
Contributor

@rodneyhbrown7 rodneyhbrown7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Waiting for ManageIQ/manageiq#16833

@bdunne
Copy link
Member Author

bdunne commented Jan 19, 2018

@miq-bot add_labels gaprindashvili/yes

@agrare agrare self-assigned this Jan 23, 2018
@Fryguy Fryguy merged commit 9a9be97 into ManageIQ:master Feb 16, 2018
@Fryguy Fryguy added the bug label Feb 16, 2018
@Fryguy Fryguy added this to the Sprint 80 Ending Feb 26, 2018 milestone Feb 16, 2018
@bdunne bdunne deleted the singularize_plural_model branch February 16, 2018 20:49
@simaishi
Copy link
Contributor

simaishi commented Mar 8, 2018

ManageIQ/manageiq#16833 is gaprindashvili/no, so changing this PR to no as well.

@felipedf felipedf mentioned this pull request Mar 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@rodneyhbrown7 rodneyhbrown7 rodneyhbrown7 approved these changes

Assignees

@agrare agrare

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bdunne @miq-bot @simaishi @rodneyhbrown7 @agrare @Fryguy