Migrate model display names from locale/en.yml to plugin #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipedf
suggested changes
Feb 21, 2018
| @@ -1,4 +1,8 @@ | |||
| module ManageIQ::Providers | |||
| class Lenovo::PhysicalInfraManager::PhysicalServer < ::PhysicalServer | |||
| end | |||
|
|
|||
| def self.display_name(number = 1) | |||
There was a problem hiding this comment.
This should be defined inside the PhysicalServer Class rather then inside the module
mzazrivec
force-pushed
the
migrate_display_names_for_models
branch
from
20a4b11
to
dea2c0a
Compare
|
This pull request is not mergeable. Please rebase and repush. |
|
@mzazrivec can you rebase? |
|
@felipedf did @mzazrivec address your concerns? |
mzazrivec
force-pushed
the
migrate_display_names_for_models
branch
from
dea2c0a
to
36f7efd
Compare
|
@agrare Done |
agrare
approved these changes
Mar 27, 2018
|
This pull request is not mergeable. Please rebase and repush. |
mzazrivec
force-pushed
the
migrate_display_names_for_models
branch
from
36f7efd
to
6584f21
Compare
|
Can this be merged please? (seeing it's approved) |
|
Checked commit mzazrivec@6584f21 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work started in ManageIQ/manageiq#16596 where we want to migrate display model names from locale/en.yml into particular models, where we'll use standard gettext. Main goal here is to make this one aspect of our application pluggable.
Core PR: ManageIQ/manageiq#16836