Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lib/gem-name.rb loader in favor of namespaced file #290

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Remove lib/gem-name.rb loader in favor of namespaced file #290

merged 1 commit into from
Jun 2, 2023

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Jun 1, 2023

No description provided.

@jrafanie jrafanie mentioned this pull request Jun 1, 2023
Closed
55 tasks
@miq-bot
Copy link
Member

miq-bot commented Jun 1, 2023

Checked commit jrafanie@442602e with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare merged commit 24aeaae into ManageIQ:master Jun 2, 2023
@jrafanie jrafanie deleted the zeitwerk branch June 2, 2023 13:41
@Fryguy
Copy link
Member

Fryguy commented Jun 6, 2023

Backported to petrosian in commit 37fc860.

commit 37fc86031a262eaa83abbdfc942216f8f3c7ab28
Author: Adam Grare <adam@grare.com>
Date:   Fri Jun 2 08:16:01 2023 -0400

    Merge pull request #290 from jrafanie/zeitwerk
    
    Remove lib/gem-name.rb loader in favor of namespaced file
    
    (cherry picked from commit 24aeaae5eac187ba3185b033a7b815f3e16d00f1)

Fryguy pushed a commit that referenced this pull request Jun 6, 2023
@agrare @Fryguy
Merge pull request #290 from jrafanie/zeitwerk
37fc860 
Remove lib/gem-name.rb loader in favor of namespaced file

(cherry picked from commit 24aeaae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@agrare agrare

Labels
enhancement petrosian/backported rails7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrafanie @miq-bot @Fryguy @agrare