V4 openshift-monitoring/alertmanager-main isn't the PrometheusAlertBuffer #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This service isn't the same prometheus alert buffer that exposes the /topic/alerts API that we need for the MonitoringManager. It might be possible to configure OCPv4 with Prometheus Alert Buffer but it isn't default so we shouldn't auto-detect it.
|
Checked commit agrare@25d2a8a with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
Part of #173 |
simaishi
pushed a commit
that referenced
this pull request
May 18, 2020
…_alert_buffer V4 openshift-monitoring/alertmanager-main isn't the PrometheusAlertBuffer (cherry picked from commit e2832ed)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This service isn't the same prometheus alert buffer that exposes the /topic/alerts API that we need for the MonitoringManager.
It might be possible to configure OCPv4 with Prometheus Alert Buffer but it isn't default so we shouldn't auto-detect it.
Fixes #177