Container Template: Parse object_labels #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label enhancement |
zakiva
force-pushed
the
add_template_labels
branch
2 times, most recently
from
241b6d4
to
8e79a30
Compare
|
This pull request is not mergeable. Please rebase and repush. |
zakiva
force-pushed
the
add_template_labels
branch
from
8e79a30
to
cc899f0
Compare
|
This pull request is not mergeable. Please rebase and repush. |
cben
approved these changes
Sep 3, 2017
cben
reviewed
Sep 3, 2017
| @@ -420,14 +420,22 @@ def parse_entities(namespace_pod, namespace_config) | |||
| 'required' => true | |||
| } | |||
| ], | |||
| :objects => [] | |||
| :objects => [], | |||
| :labels => { | |||
There was a problem hiding this comment.
can you also add an example of regular labels in this test to contrast with object_labels?
zakiva
force-pushed
the
add_template_labels
branch
from
cc899f0
to
1df255a
Compare
zakiva
force-pushed
the
add_template_labels
branch
from
1df255a
to
c7aab63
Compare
|
Checked commit zakiva@c7aab63 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM again |
|
@simon3z Please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: ManageIQ/manageiq#15406
@simon3z @moolitayer Please review