Add annotations to custom attributes on summary pages for routes and templates

[liu-samuel]

Relevant PRs:
Providers-Kubernetes: ManageIQ/manageiq-providers-kubernetes#530
UI-Classic: ManageIQ/manageiq-ui-classic#9214
Core ManageIQ: ManageIQ/manageiq#23074

Cross-Repo Tests:
ManageIQ/manageiq-cross_repo-tests#879
All passing except for known failing test cases in core ManageIQ

[Fryguy]

Should this be pushed down to the kubernetes layer? Or is this a specific feature of OpenShift?

[Fryguy]

Additionally, I'm not sure smashing together annotations and attributes makes sense, but I like the idea of at least putting them under a separate key.

Annotations are pure metadata whereas labels have a functional usage in kubernetes (that is, they are the other half of selectors).

So, my original thought was separate modeling, even though technically they are just more key/value pairs at the raw data level. @agrare Would like your thoughts here.

[agrare]

Should this be pushed down to the kubernetes layer? Or is this a specific feature of OpenShift?

Routes and ContainerTemplates don't exist in kubernetes so that's why these parsers are here in the Openshift Parser Subclass

[agrare]

Additionally, I'm not sure smashing together annotations and attributes makes sense, but I like the idea of at least putting them under a separate key.

Labels / Selectors / AdditionalAttributes are all CustomAttributes with a different "section", see https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/530/files#r1657929376

So I don't think this is "smashing" together annotations and attributes since they are kept separate unless I'm missing something.

[Fryguy]

Ohh I see - I thought labels were just top level, but if they are all sectioned out, then this is great.

[agrare]

Yeah I did a double-take when I saw custom_attributes(container_group, :labels => labels, :node_selectors => node_selector_parts, :annotations => annotations) in the kubernetes PR and had to see what the custom_attributes method did.

It might be better if custom_attributes took a section argument instead of one big hash that is splits up internally but that could be a nice follow-up after these changes.

[miq-bot]

Checked commit liu-samuel@ad5ff80 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰