fix builds namespace matching #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The codeclimate issues are not relevant to this PR. |
|
@cben please review and check for implications on your current work |
cben
reviewed
Jul 11, 2017
| it "handles simple data" do | ||
| build_pod = basic_build_pod.dup |
There was a problem hiding this comment.
I think you want .deep_dup (everywhere you .dup), because you're mutating several levels inside.
Could also use .deep_merge.
enoodle
force-pushed
the
fix_builds_namespace_matching
branch
from
b526366
to
ce779e6
Compare
cben
reviewed
Jul 11, 2017
| it "links correct build pods to build configurations in same namespace" do | ||
| parse_entities('namespace_1', 'namespace_1') | ||
| expect(parser.instance_variable_get('@data')[parser.send(:path_for_entity, "build")].first[:build_config]).to eq( | ||
| parser.instance_variable_get('@data')[parser.send(:path_for_entity, "build_config")].first |
There was a problem hiding this comment.
I'd hardcode the results of path_for_entity, both for readability and because I prefer concreteness in tests.
LGTM either way.
enoodle
force-pushed
the
fix_builds_namespace_matching
branch
from
ce779e6
to
3c92391
Compare
cben
approved these changes
Jul 11, 2017
|
👍 agree that codeclimate issues are irrelevant to this. |
|
@enoodle @cben @moolitayer I have the feeling this affects fine/euwe as well. Let's have a BZ. @miq-bot add_label fine/yes |
simon3z
reviewed
Jul 11, 2017
| bc_namespace = build_pod.status.config.try(:namespace) | ||
| new_result[:build_config] = @data_index.fetch_path(path_for_entity("build_config"), | ||
| :by_namespace_and_name, | ||
| bc_namespace, bc_name) |
1 task
|
Checked commit enoodle@3c92391 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/models/manageiq/providers/openshift/container_manager/refresh_parser_spec.rb
|
|
Fine backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for a problem mentioned here: https://github.com/ManageIQ/manageiq-providers-openshift/pull/30/files#r126438382
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1469482
cc @cben @moolitayer