Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spec test for container and container_definition merger #40

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Fix spec test for container and container_definition merger #40

merged 1 commit into from
Jul 27, 2017

Conversation

zeari
Copy link

@zeari zeari commented Jul 27, 2017

Spec test changes following ManageIQ/manageiq#15393

@cben @moolitayer
cc @simon3z

cben
cben approved these changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@cben cben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I arrived at same changes :)

@cben
Copy link
Contributor

cben commented Jul 27, 2017 •
edited
Loading

green 🌲 @moolitayer ready for merge

@miq-bot
Copy link
Member

miq-bot commented Jul 27, 2017

Checked commit zeari@a98769c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

moolitayer
moolitayer approved these changes Jul 27, 2017
View reviewed changes
Copy link

@moolitayer moolitayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@moolitayer moolitayer merged commit e6ff909 into ManageIQ:master Jul 27, 2017
@cben cben mentioned this pull request Jul 27, 2017
Merged
2 tasks
@moolitayer moolitayer added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cben cben cben approved these changes

@moolitayer moolitayer moolitayer approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeari @cben @miq-bot @moolitayer