Change saver_strategy value to String #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roundtrip through JSON. Since the API now exposes Settings, it's not possible to set Symbols as values. The saver_strategy was fixed in ManageIQ/manageiq#17168 to support String values, and the next step is to remove all Symbols from the Settings. ManageIQ/manageiq#17201 https://bugzilla.redhat.com/show_bug.cgi?id=1558031
|
Checked commit cben@e96c13f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
cben
changed the title
|
@Fryguy @moolitayer please review - open shift counterpart to ManageIQ/manageiq-providers-kubernetes#246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbols in configuration values are problematic because Symbols do not roundtrip through JSON. Since the API now exposes Settings, it's not possible to set Symbols as values. The saver_strategy was fixed in ManageIQ/manageiq#17168 to support String values, and the next step is to remove all Symbols from the Settings.
ManageIQ/manageiq#17201
https://bugzilla.redhat.com/show_bug.cgi?id=1558031
@miq-bot add-labels bug, gaprindashvili/yes
@Fryguy @moolitayer please review. This is similar to ManageIQ/manageiq-providers-kubernetes#246.