Restore deleted before_install #775
Conversation
|
Checked commit Fryguy@65cd2fb with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
| sudo make install | ||
|
|
||
| # Enable the qpid_proton bundler group | ||
| [ -z "$BUNDLE_WITH" ] && bundle config with qpid_proton |
There was a problem hiding this comment.
@agrare Technically this failed with
bin/before_install: line 34: bundle: command not found
because we don't have Ruby yet, and I'm not sure why it doesn't have BUNDLE_WITH in the env like in ManageIQ/manageiq-providers-nuage#267
There was a problem hiding this comment.
Does it work with BUNDLE_WITH like nuage has?
There was a problem hiding this comment.
It seems to work regardless (both repos passed), but maybe the tests themselves are gated somehow that I'm not seeing?
There was a problem hiding this comment.
We do config.filter_run_excluding(:qpid_proton) unless ENV['CI'] || Gem.loaded_specs.key?(:qpid_proton) so it looks like this would exclude those tests if qpid_proton weren't installed.
Seems like we'd want to never skip on ENV['CI'] regardless of if qpid_proton were available, since that would indicate something was wrong with the env setup.
Okay I'll convert this to use the env var like nuage and make sure the qpid_proton event_catcher specs are running.
No description provided.